Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.eth-utils: 1.7.0 -> 1.8.4 #82165

Merged
merged 2 commits into from Mar 10, 2020
Merged

pythonPackages.eth-utils: 1.7.0 -> 1.8.4 #82165

merged 2 commits into from Mar 10, 2020

Conversation

jluttine
Copy link
Member

@jluttine jluttine commented Mar 9, 2020

Motivation for this change

Upgrade Python package eth-utils and eth-typing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jluttine jluttine mentioned this pull request Mar 9, 2020
Closed
10 tasks
jonringer
jonringer approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[19 built, 77 copied (103.7 MiB), 35.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/82165
16 package built:
electron-cash electrum keepkey_agent python37Packages.eth-typing python37Packages.eth-utils python37Packages.keepkey python37Packages.rlp python37Packages.trezor trezor_agent python38Packages.eth-typing python38Packages.eth-utils python38Packages.keepkey python38Packages.keepkey_agent python38Packages.rlp python38Packages.trezor python38Packages.trezor_agent

@jonringer
Copy link
Contributor

@GrahamcOfBorg build electrum

@jonringer jonringer merged commit 5b676cf into NixOS:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jluttine @jonringer