Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mesos: Remove kevincox as maintainer. #82160

Merged
merged 1 commit into from Mar 13, 2020
Merged

mesos: Remove kevincox as maintainer. #82160

merged 1 commit into from Mar 13, 2020

Conversation

kevincox
Copy link
Contributor

@kevincox kevincox commented Mar 9, 2020 •
edited

kevincox no longer uses mesos so is not a suitable maintainer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kevincox kevincox requested a review from rushmorem March 9, 2020 16:23
@alyssais
Copy link
Member

I think one your commit messages is wrong. The both say “mesos”, but you’re removing yourself as maintainer for two packages.

@kevincox
mesos: Remove kevincox as maintainer.
e46fd92 
kevincox no longer uses mesos so is not a suitable maintainer.
@kevincox
Copy link
Contributor Author

kevincox commented Mar 13, 2020 •
edited

I've squashed the two commits so the description is reasonable.

@kevincox kevincox merged commit 4aaf186 into master Mar 13, 2020
@kevincox kevincox deleted the kevincox-mesos-maintainer branch March 13, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rushmorem rushmorem Awaiting requested review from rushmorem

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevincox @alyssais