Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python packages.holidays 0.10.1 #82162

Merged
merged 3 commits into from Mar 13, 2020
Merged

Python packages.holidays 0.10.1 #82162

merged 3 commits into from Mar 13, 2020

Conversation

jluttine
Copy link
Member

@jluttine jluttine commented Mar 9, 2020

Motivation for this change

Upgrade Python package holidays. Needed to add a few dependencies too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Mar 10, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

[13 built, 3 copied (2.5 MiB), 0.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/82162
9 package built:
python27Packages.convertdate python27Packages.holidays python27Packages.pymeeus python37Packages.convertdate python37Packages.holidays python37Packages.pymeeus python38Packages.convertdate python38Packages.holidays python38Packages.pymeeus

pkgs/development/python-modules/convertdate/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pymeeus/default.nix Outdated Show resolved Hide resolved
@jluttine jluttine force-pushed the pythonPackages.holidays-0.10.1 branch from c189531 to e5d5e1e Compare March 11, 2020 08:01
@jluttine
Copy link
Member Author

@jonringer Thanks for the review. I made the requested fixes.

jonringer
jonringer approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/82162
9 package built:
python27Packages.convertdate python27Packages.holidays python27Packages.pymeeus python37Packages.convertdate python37Packages.holidays python37Packages.pymeeus python38Packages.convertdate python38Packages.holidays python38Packages.pymeeus

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.convertdate python27Packages.holidays python27Packages.pymeeus python37Packages.convertdate python37Packages.holidays python37Packages.pymeeus python38Packages.convertdate python38Packages.holidays python38Packages.pymeeus

@jonringer jonringer merged commit b7cdf99 into NixOS:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jluttine @jonringer