Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

androidenv: use runtimeShell instead of stdenv.shell #82119

Merged
merged 1 commit into from Aug 16, 2020

Conversation

lucafavatella
Copy link
Contributor

@lucafavatella lucafavatella commented Mar 9, 2020

Motivation for this change

From #56408 :

Whenever we create scripts that are installed to $out, we must use runtimeShell
in order to get the shell that can be executed on the machine we create the
package for. This is relevant for cross-compiling. The only use case for
stdenv.shell are scripts that are executed as part of the build system.

Things done

I smoke tested this alongside another change I made. I hope this is sufficient, please advise me otherwise.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
      • Ubuntu Bionic on Travis CI.
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date - Not applicable
  • Fits CONTRIBUTING.md.

@alyssais alyssais merged commit 7802608 into NixOS:master Aug 16, 2020
@lucafavatella lucafavatella deleted the androidenv-runtime-shell branch August 23, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants