Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swiProlog: openssl 1.0.2 -> openssl 1.1 #82081

Merged
merged 1 commit into from Mar 17, 2020
Merged

swiProlog: openssl 1.0.2 -> openssl 1.1 #82081

merged 1 commit into from Mar 17, 2020

Conversation

kquick
Copy link
Contributor

@kquick kquick commented Mar 9, 2020

Motivation for this change

swiProlog is currently configured to use the deprecated OpenSSL 1.0.2 version. The swiProlog upstream has supported OpenSSL 1.1 since mid-2017; this patch updates the nix specification.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

marsam
marsam requested changes Mar 9, 2020
View reviewed changes
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@vcunat vcunat requested a review from meditans March 9, 2020 07:33
@vcunat
Copy link
Member

vcunat commented Mar 9, 2020

Let's test builds, including darwin.
@GrahamcOfBorg build swiProlog swiPrologWithGui

@vcunat vcunat added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 9, 2020
@vcunat
Copy link
Member

vcunat commented Mar 9, 2020

Hmm, the aarch64 problem when building docs might be just not handling too large make-parallelism well. We do have at least one recent successful build: https://hydra.nixos.org/build/112550303

@kquick
Copy link
Contributor Author

kquick commented Mar 17, 2020

@marsam: I updated the PR, and @vcunat indicates the failing test is probably just a parallelism issue on the builder. I think this is ready for merging to master.

@marsam marsam merged commit ffad9c7 into NixOS:master Mar 17, 2020
@kquick kquick deleted the swiprolog_openssl_1_1 branch March 17, 2020 04:57
vcunat pushed a commit that referenced this pull request Mar 24, 2020
@marsam @vcunat
Merge #82081: swiProlog: openssl 1.0.2 -> openssl 1.1
976fd6a 
(cherry picked from commit ffad9c7)
This is unbreaking the package.
@vcunat vcunat removed the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam requested changes

@vcunat vcunat vcunat left review comments

@meditans meditans Awaiting requested review from meditans

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kquick @vcunat @marsam