Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ppx_deriving_yojson: 3.5.1 -> 3.5.2 #82085

Merged
merged 2 commits into from Mar 10, 2020
Merged

ppx_deriving_yojson: 3.5.1 -> 3.5.2 #82085

merged 2 commits into from Mar 10, 2020

Conversation

anmonteiro
Copy link
Member

@anmonteiro anmonteiro commented Mar 9, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam
Copy link
Contributor

marsam commented Mar 9, 2020 •
edited by vbgl

@GrahamcOfBorg build fstar ocamlPackages.earlybird

vbgl
vbgl reviewed Mar 10, 2020
View reviewed changes
pkgs/development/ocaml-modules/ppx_deriving_yojson/default.nix

minimumOCamlVersion = "4.04";

src = fetchFromGitHub {
owner = "ocaml-ppx";
repo = "ppx_deriving_yojson";
rev = "v${version}";
sha256 = "13nscby635vab9jf5pl1wgmdmqw192nf2r26m3gr01hp3bpn38zh";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hash seems wrong:

hash mismatch in fixed-output derivation '/nix/store/rcws8q6q6k84gs0vxsvwkk2x6xpkiy5c-source':
wanted: sha256:098rpjbykp7ffhs62mgxlk7349l665xh1w1m8ldj6rjb690cc945
got: sha256:1vbhmnhnj1aa4jrp8xqi52nggwj7vrml83z2j0r0qzvl65v02mc0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed -- not sure if my mistake or if it changed under me for some reason. Anyways, fixed now.

@vbgl
Copy link
Contributor

vbgl commented Mar 10, 2020

@GrahamcOfBorg build fstar ocamlPackages.earlybird

@vbgl vbgl merged commit 7698d73 into NixOS:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl vbgl left review comments

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anmonteiro @marsam @vbgl