Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hepmc3: 3.1.2 -> 3.2.0, add python support #82170

Merged
merged 3 commits into from Mar 24, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Mar 9, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pythonPackages.hepmc3 should cover this functionality
@veprbl
Copy link
Member Author

veprbl commented Mar 9, 2020

@GrahamcOfBorg build python27Packages.hepmc3 python37Packages.hepmc3 python38Packages.hepmc3

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with how python is developed, I don't think saying "just use this other package" is enough (in regards to pyhepmc).

pkgs/top-level/python-packages.nix Show resolved Hide resolved
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM

python27Packages.bacpypes python37Packages.bacpypes python38Packages.bacpypes

@jonringer jonringer merged commit 1ca3c56 into NixOS:master Mar 24, 2020
@veprbl veprbl deleted the pr/hepmc3_3_2_0 branch December 1, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants