Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btrfs-dedupe: remove broken and abandoned package #82124

Merged
merged 1 commit into from Mar 13, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 9, 2020

This package was last released in 2017, and no longer compiles with the latest
Rust compiler. It has just 1 commit from someone other than the original author
and appears to be a dead project.

ZHF: #80379

Also removes a legacy cargo fetcher call for #79975

This package was last released in 2017, and no longer compiles with the latest
Rust compiler. It has just 1 commit from someone other than the original author
and appears to be a dead project.
@marsam
Copy link
Contributor

marsam commented Mar 9, 2020

cc: @ikervagyok

@ikervagyok
Copy link
Contributor

please have a look at this as well: #67705

@bhipple
Copy link
Contributor Author

bhipple commented Mar 9, 2020

Usually, the release notes are mainly targeted towards NixOS modules and big packages within. Since this has been broken for 1+ years and is clearly abandoned upstream, I doubt anyone's really using it and we can probably just nuke it without even leaving an alias behind. What do you think?

@ikervagyok
Copy link
Contributor

wanted to do that forever, then i got sidetracked - go for it ;)

@ikervagyok
Copy link
Contributor

to clarify: you can either drop a note in the release notes or not, since as you said, it's broken beyond repair.
the alias is also more or less useless, so if it's needed you can copy that stuff, otherwise leave it as is and just remove the package...

@bhipple
Copy link
Contributor Author

bhipple commented Mar 10, 2020

Ok, I'd say we go for no alias and no release notes, for this particular one, since it's so clear no one has used this for 1+ years. In the unlikely event someone is disrupted, they'd need to run git log anyways to find a historical checkout of NixPkgs where this still built.

Let's merge this as-is.

@bhipple
Copy link
Contributor Author

bhipple commented Mar 12, 2020

@marsam mind giving this (and the ZFH 20.03 backport) a merge?

@marsam marsam merged commit efac165 into NixOS:master Mar 13, 2020
@marsam
Copy link
Contributor

marsam commented Mar 13, 2020

Sorry for the delay. Backported to 20.03 in e4844bd69d1

@marsam marsam mentioned this pull request Mar 13, 2020
10 tasks
@bhipple bhipple deleted the remove/btrfs-dedupe branch June 2, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants