Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minecraft: install missing gsettings schemas #82156

Merged
merged 1 commit into from Mar 10, 2020
Merged

minecraft: install missing gsettings schemas #82156

merged 1 commit into from Mar 10, 2020

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Mar 9, 2020

Motivation for this change

I don't like to contribute unfree software but someone asked me a favor.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS 20.03
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change
  • Tested execution of all binary files (minecraft-launcher)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from cpages and ryantm March 9, 2020 15:27
@infinisil
Copy link
Member

What's this for?

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 9, 2020

There are few places in the launcher that open the gtk file picker. Without this the program crashes right away.

infinisil
infinisil approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, that does indeed make it work, nice!

@infinisil infinisil merged commit bc98978 into NixOS:master Mar 10, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Mar 10, 2020
@infinisil @dtzWill
Merge pull request NixOS#82156 from rnhmjoj/minecraft
c60727c 
minecraft: install missing gsettings schemas
(cherry picked from commit bc98978)
@rnhmjoj rnhmjoj deleted the minecraft branch April 7, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

@cpages cpages Awaiting requested review from cpages

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rnhmjoj @infinisil