mattermost: 5.15.0 -> 5.20.1 #82172
Closed
mattermost: 5.15.0 -> 5.20.1 #82172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jslight90
force-pushed
the
mattermost-5.20
branch
from
7a49995
to
18eb593
Compare
nh2
reviewed
May 29, 2020
| @@ -207,8 +206,7 @@ in | |||
| PermissionsStartOnly = true; | |||
| User = cfg.user; | |||
| Group = cfg.group; | |||
| ExecStart = "${pkgs.mattermost}/bin/mattermost" + | |||
| (lib.optionalString (!cfg.mutableConfig) " -c ${database}"); | |||
There was a problem hiding this comment.
Why is this changing?
Was it wrong before, or is there a change in the verison upgrade that makes it wrong?
Please also write the answer into the commit message.
|
This new version unbreaks new installs for me on 20.03: #89194 (comment) |
10 tasks
ali-abrar
reviewed
Jul 17, 2020
There was a problem hiding this comment.
This is below the minimum version recommended by mattermost.
|
We're past this version now. If the service needs updates, could you add that in a separate PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update version of Mattermost.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)