[20.03] firefox: Fix AArch64 build #82173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andir
approved these changes
Mar 9, 2020
* The 'arm.patch' patch doesn't apply anymore. * The 'build-arm-libopus.patch' patch isn't required anymore. * See the mozilla phabricator link for the added patch. Additionally, we are now *always* undconditionally applying all patches to all architectures. That is, unless they have undesirable side-effects, but those might not be fit for inclusion. By applying all patches all the time, they'll be removed or replaced when they stop applying. (cherry picked from commit d4446c5)
samueldr
force-pushed
the
20.03/aarch64/firefox
branch
from
e371541
to
6291285
Compare
|
(While I did switch the implementation after @andir approved, I'm positive the approval also applies to a simple backport.) |
|
Tested build for:
On platforms:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #81211
The backport can be applied, unlike 19.09.
Currently waiting on builds.