Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rPackages.rzmq: add pkgs.pkgconfig and patchShebangs configure #82127

Closed
wants to merge 2 commits into from
Closed

rPackages.rzmq: add pkgs.pkgconfig and patchShebangs configure #82127

wants to merge 2 commits into from

Conversation

PhDyellow
Copy link

Motivation for this change

I was building the R package rzmq on the nixos-unstable channel in NixOS, commit hash 82b54d4.

I was building into a nix-shell environment.

The build was failing with

building '/nix/store/kl3v68zrilcm4k590q71mwvibp7grmbq-r-rzmq-0.9.6.drv'...
unpacking sources
unpacking source archive /nix/store/41ap5wvzpkl4dx7qa9z32i55lr6zz6wi-rzmq_0.9.6.tar.gz
source root is rzmq
setting SOURCE_DATE_EPOCH to timestamp 1551477009 of file rzmq/MD5
patching sources
configuring
building
running tests
installing
* installing *source* package 'rzmq' ...
** package 'rzmq' successfully unpacked and MD5 sums checked
** using staged installation
sh: ./configure: not found
Warning in system(cmd) : error in running command
ERROR: configuration failed for package 'rzmq'
* removing '/nix/store/f61pjsk2pq706zawq7hnmkgnr5w8q3vq-r-rzmq-0.9.6/library/rzmq'
builder for '/nix/store/kl3v68zrilcm4k590q71mwvibp7grmbq-r-rzmq-0.9.6.drv' failed with exit code 1

Making the changes in this PR successfully built rPackages.rzmq.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

rPackages.rzmq: add pkgs.pkgconfig and patchShebangs configure
f055203 
rzmq would not build in nixos-unstable, "patchShebangs configure"
had not been added to the preConfigure phase.

Recent versions of rzmq can also make use of pkgs.pkgconfig
during the build phase.
@PhDyellow PhDyellow requested a review from peti as a code owner March 9, 2020 05:26
@PhDyellow PhDyellow closed this May 1, 2020
@PhDyellow PhDyellow deleted the f_rzmq branch May 1, 2020 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PhDyellow @Janik-Haag