Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipbt: init at 20190601.d1519e0 #82177

Merged
merged 1 commit into from Mar 31, 2020
Merged

ipbt: init at 20190601.d1519e0 #82177

merged 1 commit into from Mar 31, 2020

Conversation

tckmn
Copy link
Member

@tckmn tckmn commented Mar 9, 2020

Motivation for this change

Adds a derivation for the ipbt program.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

doronbehar
doronbehar requested changes Mar 12, 2020
View reviewed changes
pkgs/tools/misc/ipbt/default.nix Outdated
@@ -0,0 +1,22 @@
{ stdenv, fetchurl, perl, ncurses }:

let version = "20190601.d1519e0"; in stdenv.mkDerivation {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let version = "20190601.d1519e0"; in stdenv.mkDerivation {
stdenv.mkDerivation rec {

pkgs/tools/misc/ipbt/default.nix Outdated
{ stdenv, fetchurl, perl, ncurses }:

let version = "20190601.d1519e0"; in stdenv.mkDerivation {
inherit version;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
inherit version;
version = "20190601.d1519e0";

timokau
timokau requested changes Mar 31, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit messages don't actually match CONTRIBUTING.md. Please revisit it, especially the section on commit messages.

pkgs/tools/misc/ipbt/default.nix Outdated

meta = with stdenv.lib; {
description = "A high-tech ttyrec player for Unix";
homepage = https://www.chiark.greenend.org.uk/~sgtatham/ipbt/;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please quote the homepage (NixOS/rfcs#45)

pkgs/tools/misc/ipbt/default.nix Outdated
meta = with stdenv.lib; {
description = "A high-tech ttyrec player for Unix";
homepage = https://www.chiark.greenend.org.uk/~sgtatham/ipbt/;
license = licenses.mit;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't align on =.

@tckmn
Copy link
Member Author

tckmn commented Mar 31, 2020

@timokau sorry about that -- i've made those changes and squashed everything back into one commit

timokau
timokau approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect now, thank you!

@timokau timokau merged commit 1b6245b into NixOS:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar requested changes

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tckmn @timokau @doronbehar