Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alot: add patch for email composition #82099

Merged
merged 1 commit into from Mar 10, 2020
Merged

alot: add patch for email composition #82099

merged 1 commit into from Mar 10, 2020

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Mar 9, 2020

Motivation for this change

This version is not usable without this patch.
See pazz/alot#1468.

This probably needs to be back-ported to release-20.03 too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pacien
alot: add patch for email composition
b6d4530 
This version is not usable without this patch.
See pazz/alot#1468.
@ofborg ofborg bot requested a review from oxzi March 9, 2020 02:11
@marsam marsam merged commit 07789d9 into NixOS:master Mar 10, 2020
@marsam
Copy link
Contributor

marsam commented Mar 10, 2020

Thanks!

@pacien
Copy link
Contributor Author

pacien commented Mar 10, 2020 •
edited

This probably needs to be back-ported to release-20.03 too.
See #82223

@pacien pacien mentioned this pull request Mar 10, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@oxzi oxzi Awaiting requested review from oxzi

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pacien @marsam