Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chirp: 20200213 -> 20200227 #82078

Closed
wants to merge 1 commit into from
Closed

Conversation

andrew-d
Copy link
Contributor

@andrew-d andrew-d commented Mar 8, 2020

Motivation for this change

Fix for this Yaesu bug.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

r? @the-kenny

@andrew-d
Copy link
Contributor Author

@the-kenny - Ping! Anything I can do to help get this approved?

@andrew-d
Copy link
Contributor Author

Superseded by #85309

@andrew-d andrew-d closed this Apr 22, 2020
@andrew-d andrew-d deleted the andrew/chirp branch April 22, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant