Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vim_configurable: fix default gui for darwin #82097

Merged
merged 1 commit into from Mar 28, 2020
Merged

vim_configurable: fix default gui for darwin #82097

merged 1 commit into from Mar 28, 2020

Conversation

millerjason
Copy link
Contributor

@millerjason millerjason commented Mar 9, 2020 •
edited

Motivation for this change

This PR closes #47452 which has been an open issue since 2018.

Presently a unaltered compile of vim_configurable under Darwin will generate the following error on recent versions OS versions (in my case 10.15):

mbyte.c:123:12: fatal error: 'gdk/gdkx.h' file not found
#  include <gdk/gdkx.h>
           ^~~~~~~~~~~~
1 error generated.

The "gtk2", "auto", or "athena" GUIs are supported under Darwin and those build cleanly. There may be ways to make GTK3 work again, but I could not find any progress on that approach for this longstanding bug.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 6.topic: vim labels Mar 9, 2020
@ofborg ofborg bot requested review from equirosa and lovek323 March 9, 2020 02:01
@millerjason
Copy link
Contributor Author

@lovek323 @equirosa This is ready for review, feel free to pull in someone else if you don't have a recent macOS to review on. Thanks.

@LnL7 LnL7 merged commit 67938c1 into NixOS:master Mar 28, 2020
@millerjason millerjason deleted the bugfix/vim_configurable branch March 28, 2020 12:04
@smancill smancill mentioned this pull request Jul 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

@equirosa equirosa Awaiting requested review from equirosa

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: vim 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vim: Configurable.nix fails with 'gdk/gdkx.h' file not found
2 participants
@millerjason @LnL7