Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger: remove old version 2.6.3 #82096

Merged
merged 1 commit into from Mar 15, 2020
Merged

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 9, 2020

Version 2.6.3 was released > 5 years ago and has been marked as broken for some
time. It is time to remove it.
https://github.com/ledger/ledger/releases/tag/v2.6.3

This also documents why ledger3 cannot yet build with boost >= 1.67

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Version 2.6.3 was released > 5 years ago and has been marked as broken for some
time. It is time to remove it.

This also documents why ledger3 cannot yet build with boost >= 1.67
'';

platforms = stdenv.lib.platforms.all;
broken = true; # https://hydra.nixos.org/build/59124559/nixlog/1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that it's been marked as broken since 2017!

Copy link
Contributor

@OmnipotentEntity OmnipotentEntity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good to me.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/82096
39 package marked as broken and skipped:
clang-sierraHack digitalbitbox gdata-sharp linuxPackages_4_4.evdi linuxPackages_hardkernel_4_14.bcc linuxPackages_hardkernel_4_14.can-isotp linuxPackages_hardkernel_4_14.chipsec linuxPackages_hardkernel_4_14.digimend linuxPackages_hardkernel_4_14.evdi linuxPackages_hardkernel_4_14.mba6x_bl linuxPackages_hardkernel_4_14.r8125 linuxPackages_hardkernel_4_14.r8168 linuxPackages_hardkernel_4_14.rtlwifi_new octave-jit php72Packages-unit.php_excel php72Packages-unit.v8 php72Packages-unit.v8js php72Packages.php_excel php72Packages.v8 php72Packages.v8js php73Packages-unit.php_excel php73Packages-unit.v8 php73Packages.php_excel php73Packages.v8 php74Packages-unit.couchbase php74Packages-unit.pcs php74Packages-unit.php_excel php74Packages-unit.v8 php74Packages.couchbase php74Packages.pcs php74Packages.php_excel php74Packages.v8 python27Packages.caffe python27Packages.flitBuildHook python37Packages.nixpart python37Packages.notify python38Packages.notify python38Packages.pyblock qes

@jonringer jonringer merged commit ca84a48 into NixOS:master Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants