Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.MojoPg: init at 4.18 #82189

Merged
merged 1 commit into from Mar 23, 2020
Merged

perlPackages.MojoPg: init at 4.18 #82189

merged 1 commit into from Mar 23, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Mar 9, 2020

Motivation for this change

Adds the Mojo::Pg Perl module

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp
Copy link
Member Author

stigtsp commented Mar 10, 2020

@volth That would be practical as most of these derivations can be taken straight from nix-generate-from-cpan.

@aanderse
Copy link
Member

Makes sense, though I've never looked into how that happens. Would it be much work? Are there people willing to do tho work? Or can an existing bot already do this, it just needs to be configured to do so...?

@stigtsp
Copy link
Member Author

stigtsp commented Mar 10, 2020 •
edited

Some thoughts:

  • Using CPAN::Mini, MetaCPAN::API or cpan.org to download metadata for all modules. PAUSE signs a per author manifest containing sha256 sums.

  • perl dependencies:
    Some modules have dependencies defined in the meta, some don't. Most modules have tests, so it might be possible to figure out missing dependencies by parsing Can't locate Foo/Bar.pm in @INC errors.

  • non-perl dependencies:

    • From existing derivations in nixpkgs
    • By comparing from other distributions (Debians libjpeg62-turbo -> will map
      to nixpkgs.libjpeg_turbo, etc). Is this a viable approach?
    • ... other approaches?

  • Generate derivations similar to nix-generate-from-cpan

I'll try to spend some time on this issue. Discussed a similar approach for packaging all the Raku modules with @adisbladis

@stigtsp
Copy link
Member Author

stigtsp commented Mar 23, 2020

Is this PR ok btw?

@aanderse
Copy link
Member

@GrahamcOfBorg build perlPackages.MojoPg perdevelPackages.MojoPg

@aanderse aanderse merged commit 68a963f into NixOS:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stigtsp @aanderse