New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
folding@home: 6.02 -> 7.5.1 #82192
folding@home: 6.02 -> 7.5.1 #82192
Conversation
1eead45
to
d75c5ec
Compare
This comment has been minimized.
This comment has been minimized.
How to test the PR
{ pkgs, ... }:
{
services.foldingathome.enable = true;
environment.systemPackages = with pkgs; [ fahviewer fahcontrol ];
}
The Covid-19 research happens in the "Any Disease" group, it doesn't look like it's possible to select it specifically. |
087d20e
to
4d0953f
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/fight-covid-19-with-folding-home-and-nixos/6202/1 |
Partial duplicate of #81768 |
You might also want to update the nixos module. It seems quite out of date |
@rissson what do you mean, I rewrote it from scratch? :D |
@zimbatm yes indeed I was looking at the old one. It would be nice to also have an option for the config.xml file |
@rissson: now the FAHClient can be started with extra options and defaults to the NixOS Team ID. I think this approach is more reliable than providing the config.xml since the service expects the file to be mutable. |
Thanks! I've started this on a few boxes now. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
So you recommend modifying the config with FAHControl then? |
FAHClient should configure the xml when started with the right arguments |
The v7 series is very different. This commit introduces the 3 packages: fahclient, fahcontrol and fahviewer. It also rebuilds the NixOS module to map better with the new client.
Ok I think this is ready. Rebased and squashed. I also added the NixOS module renamed options for back-compat. |
Maybe add support for passkey also? https://foldingathome.org/support/faq/points/passkey/ (Since the .deb installer prompts for this) |
I'd rather get this merged. The passkey support doesn't seem strictly necessary to me and can be added using FAHControl. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
programs seem to work
[13 built, 198 copied (1226.2 MiB), 235.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/82192
1 package blacklisted:
tests.nixos-functions.nixos-test
3 package built:
fahclient fahcontrol fahviewer
Motivation for this change
Find a cure to Covid-19
Update folding@home. Things have changed quite a bit so I rebuilt everything from scratch.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)