Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix grammar / typo in NixPkgs GNOME manual #82191

Merged
merged 1 commit into from Mar 10, 2020
Merged

doc: fix grammar / typo in NixPkgs GNOME manual #82191

merged 1 commit into from Mar 10, 2020

Conversation

das-g
Copy link
Member

@das-g das-g commented Mar 9, 2020

Motivation for this change

Without this change, the sentence doesn't make much sense.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Mar 9, 2020
vcunat
vcunat approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added another tiny change in the same sentence in dcd33b7.

vcunat added a commit that referenced this pull request Mar 10, 2020
@vcunat
Merge #82191: doc: improve grammar in nixpkgs GNOME manual
5ea0258
@vcunat vcunat merged commit a7c53f7 into NixOS:master Mar 10, 2020
vcunat added a commit that referenced this pull request Mar 10, 2020
@vcunat
Merge #82191: doc: improve grammar in nixpkgs GNOME manual
187a4be 
(cherry picked from commit 5ea0258)
vcunat added a commit that referenced this pull request Mar 10, 2020
@vcunat
Merge #82191: doc: improve grammar in nixpkgs GNOME manual
84bf463 
(cherry picked from commit 5ea0258)
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Mar 10, 2020
@vcunat @dtzWill
Merge NixOS#82191: doc: improve grammar in nixpkgs GNOME manual
d500492 
(cherry picked from commit 5ea0258)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@das-g @vcunat