Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Fix signal-desktop #82148

Merged
merged 1 commit into from Mar 12, 2020
Merged

tests: Fix signal-desktop #82148

merged 1 commit into from Mar 12, 2020

Conversation

devhell
Copy link
Contributor

@devhell devhell commented Mar 9, 2020

This test fails due to OOM on the VM. Setting the memory of the VM to
1024 lets the test succeed.

Cc: @flokli

Motivation for this change

The test failed repeatedly on a private Hydra instance and when tested on a local machine.

Things done

Set virtualisation.memorySize = 1024;

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This test fails due to OOM on the VM. Setting the memory of the VM to
1024 lets the test succeed.

Cc: @flokli
@devhell
Copy link
Contributor Author

devhell commented Mar 11, 2020

@flokli Sorry, I don't mean to be pushy, but it would be great if this test could be fixed. ;-)

@flokli
Copy link
Contributor

flokli commented Mar 12, 2020

Sorry, I fully agree. This also probably should get into 20.03 and 19.09, shouldn't it?

@flokli flokli merged commit 2220060 into NixOS:master Mar 12, 2020
@flokli
Copy link
Contributor

flokli commented Mar 12, 2020

backported to 20.03 in 2ba4461, to 19.09 in 84af403.

@devhell devhell deleted the tests_signal-desktop branch March 12, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants