Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab: 12.8.2 -> 12.8.5 #82142

Merged
1 commit merged into from Mar 9, 2020
Merged

gitlab: 12.8.2 -> 12.8.5 #82142

1 commit merged into from Mar 9, 2020

Conversation

ghost
Copy link

@ghost ghost commented Mar 9, 2020

https://about.gitlab.com/releases/2020/03/09/gitlab-12-8-5-released/

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

CC @talyz for testing

@ofborg ofborg bot requested review from globin, ehmry, fpletz and talyz March 9, 2020 12:16
@ghost
Copy link
Author

ghost commented Mar 9, 2020

@GrahamcOfBorg test gitlab

@talyz talyz mentioned this pull request Mar 9, 2020
Closed
10 tasks
@talyz
Copy link
Contributor

talyz commented Mar 9, 2020

Looks good! Works well in my tests and the nixos tests 👍

@ghost ghost merged commit f391999 into NixOS:master Mar 9, 2020
ghost pushed a commit that referenced this pull request Mar 9, 2020
gitlab: 12.8.2 -> 12.8.5 (#82142)
7f2658b 
https://about.gitlab.com/releases/2020/03/09/gitlab-12-8-5-released/
(cherry-picked from f391999)
ghost pushed a commit that referenced this pull request Mar 9, 2020
gitlab: 12.8.2 -> 12.8.5 (#82142)
58b019c 
https://about.gitlab.com/releases/2020/03/09/gitlab-12-8-5-released/
(cherry-picked from commit f391999)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

@ehmry ehmry Awaiting requested review from ehmry

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@talyz