Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

habitat: 0.30.2 -> 0.90.6 #82213

Merged
merged 1 commit into from Mar 18, 2020
Merged

habitat: 0.30.2 -> 0.90.6 #82213

merged 1 commit into from Mar 18, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 10, 2020

The build has been broken on master for a very long time, for want of an
upgrade. This continues the effort put forth here:
#63105

Note that while there are newer versions than this, upgrading to those requires
getting some Cargo protobuf dependencies to compile. Since this fixes the
failing build, it seems like a good start.

Also includes Rust upgrade for #79975

Changelog:
https://github.com/habitat-sh/habitat/blob/master/CHANGELOG.md#0906-2019-11-13

CC @rushmorem @boj

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
Copy link
Contributor Author

bhipple commented Mar 10, 2020

This compiles and passes its entire test suite, but I haven't done any work beyond that to verify.

@ofborg ofborg bot requested a review from rushmorem March 10, 2020 02:39
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/128

@Mic92
Copy link
Member

Mic92 commented Mar 15, 2020

@GrahamcOfBorg build habitat

@bhipple
Copy link
Contributor Author

bhipple commented Mar 15, 2020

Hmm, Darwin is failing; should I just restrict platforms or is there a way I can test? I only have a Linux machine, so I was carrying over some of the Darwin stuff from the previous PR's attempts.

@Mic92
Copy link
Member

Mic92 commented Mar 16, 2020

It is also not clear to me how they build the thing on macOS actually: https://github.com/Homebrew/homebrew-cask/blob/master/Casks/hab.rb#L6
I don't see any CI code for building the macOS binary.
cc @davidMcneil ?

@bhipple
habitat: 0.30.2 -> 0.90.6
b7ef716 
The build has been broken on master for a very long time, for want of an
upgrade. This continues the effort put forth here:
NixOS#63105

Note that while there are newer versions than this, upgrading to those requires
getting some Cargo protobuf dependencies to compile. Since this fixes the
failing build, it seems like a good start.

Upstream does not appear to have any Darin builds in their CI, and we do not
have a Darwin maintainer available, so this disables it as well.
@bhipple
Copy link
Contributor Author

bhipple commented Mar 17, 2020

I have updated to simply remove the Darwin variant for the time being. Since this fixes the broken linux build it's still an improvement over the status quo.

@bhipple
Copy link
Contributor Author

bhipple commented Mar 17, 2020

@GrahamcOfBorg build habitat

@bhipple bhipple mentioned this pull request Mar 17, 2020
Closed
@Mic92 Mic92 merged commit 053ad4e into NixOS:master Mar 18, 2020
@alyssais
Copy link
Member

Would have been nicer to mark broken on Darwin, since upstream does support the software there.

@drewrisinger drewrisinger mentioned this pull request May 4, 2020
Closed
10 tasks
@bhipple bhipple deleted the fix/habitat branch May 10, 2020 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rushmorem rushmorem Awaiting requested review from rushmorem

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bhipple @nixos-discourse @Mic92 @alyssais