Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kitty: remove unused nativeBuildInputs on macOS #82184

Merged
merged 1 commit into from Mar 9, 2020
Merged

kitty: remove unused nativeBuildInputs on macOS #82184

merged 1 commit into from Mar 9, 2020

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Mar 9, 2020

Motivation for this change

These two dependencies were used to generate the PNG icons that would later be converted to the icon for the macOS app. The PNGs are now stored in git and are not generated during the build anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Luflosi
kitty: remove unused nativeBuildInputs on macOS
1b74dfc 
These two dependencies were used to generate the PNG icons that would later be converted to the icon for the macOS app. The PNGs are now stored in git and are not generated during the build anymore.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Mar 9, 2020
@ofborg ofborg bot requested review from Ma27 and tex March 9, 2020 21:37
@veprbl
Copy link
Member

veprbl commented Mar 9, 2020

@GrahamcOfBorg build kitty

@veprbl veprbl merged commit edaceea into NixOS:master Mar 9, 2020
@veprbl
Copy link
Member

veprbl commented Mar 9, 2020

Thank you!

@Luflosi Luflosi deleted the kitty-remove-unused-nativeBuildInputs branch June 17, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Awaiting requested review from Ma27

@tex tex Awaiting requested review from tex

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Luflosi @veprbl