Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

texlive: 2019 -> 2019-final #82199

Merged
merged 4 commits into from Mar 15, 2020
Merged

texlive: 2019 -> 2019-final #82199

merged 4 commits into from Mar 15, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Mar 9, 2020

Motivation for this change

Bump to the latest version of texlive-2019.
This is WIP until the snapshot is frozen completely (expected soon).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Fixes: #81544

@veprbl
Copy link
Member Author

veprbl commented Mar 12, 2020

It seems like older versioned tarballs are retained on the tlnet-final mirrors. I've just added the support for this feature, so this should be stable enough for master.

@veprbl veprbl marked this pull request as ready for review March 12, 2020 22:18
@veprbl
Copy link
Member Author

veprbl commented Mar 12, 2020

@GrahamcOfBorg build texlive.combined.scheme-basic texlive.combined.scheme-context texlive.combined.scheme-full texlive.combined.scheme-gust texlive.combined.scheme-medium texlive.combined.scheme-minimal texlive.combined.scheme-small texlive.combined.scheme-tetex

@veprbl
Copy link
Member Author

veprbl commented Mar 14, 2020

If there are no comments, I propose to merge. I would like to push this for 20.03.

@Anton-Latukha
Copy link
Contributor

Thank you. I am awaiting this very much.

Please merge this soon because:

  1. our current nixpkgs version of TexLive is something like a year old.
  2. over that - our nixpkgs version snapshotted a nasty bug in one of the main LeTeX packages: grffile does not work with LuaTeX any more ho-tex/grffile#1, which mangled path handling of files and so broke compatibility of exporting any inclusions in files between, as in my case - Emacs Org-mode and the modern Latex3 engine LuaTeX. That bug solved upstream long ago. I need to jump through too many hoops to work around that bug snapshotted.

@veprbl
Copy link
Member Author

veprbl commented Mar 14, 2020

our current nixpkgs version of TexLive is something like a year old

Actually, the current snapshot is only 4 months old. We barely missed the grffle fix that came just two days after our current snapshot in nixpkgs-unstable.

bhipple
bhipple requested changes Mar 15, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, otherwise LGTM and everything builds. Thanks for doing this!

I definitely agree the stable, final 2019 release should be backported to 20.03.

pkgs/tools/typesetting/tex/texlive/fixHashes.awk Outdated Show resolved Hide resolved
@veprbl
texlive: reimplement fixHashes.sh in GNU Awk
d9fb53d 
The shell script doesn't work very well in non-GNU environments like
darwin. This provides an implementation that uses just a single GNU tool
- gawk, thus reduces number of points of failure.
@veprbl
texlive: 2019 -> 2019-final
9752593 
The biber package is now at 2.14, but TextBibTeX is still required.

Few changes were needed for newly introduced scripts-extra path. This
broke some of our old tricks which were relying on having writable
script directories. The changes to the script locations made buildEnv
create symlinks to the script directories instead of directories of
symlinks to scripts. The changes to texlinks.sh and texlive/TeXLive
perl path were made because of this.
@veprbl
texlive/pkgs.nix: add revision
9c4212c
@veprbl
texlive: use versioned tarballs
9f44a61 
Announced in [1], versioned tarballs allow to make sure that a
specific version is fetched. This does not guarantee that all previous
versions are retained on the main mirrors.

Logically, we would want to first try to download versioned tarballs
from any mirror and only then try the unversioned ones. But right now
we only have two mirrors and only some of the tarballs are versioned
in texlive-2019, so the order is changed to not hammer the weak
tug.org mirror.

[1] https://tug.org/pipermail/tex-live/2019-September/044086.html
@veprbl veprbl merged commit 359de1d into NixOS:master Mar 15, 2020
@veprbl veprbl deleted the pr/texlive_2019_final branch March 15, 2020 19:08
@veprbl
Copy link
Member Author

veprbl commented Mar 15, 2020 •
edited

If there are any other concerns, please, open issues.

@veprbl veprbl mentioned this pull request Mar 15, 2020
Merged
10 tasks
@veprbl veprbl added the 8.has: port to stable A PR already has a backport to the stable release. label Mar 15, 2020
@veprbl veprbl mentioned this pull request Mar 16, 2020
Merged
10 tasks
@Anton-Latukha
Copy link
Contributor

Anton-Latukha commented Mar 17, 2020 •
edited

@veprbl

Oh, you caught me, I elaborated a little. I've made assumption based on the version of packages I was looking between CTAN and TeX Live on the system, I remembered version dates of April.

I am so far a newbie in TeX Live.

Thank you for this.

How much effort/computation the update takes?

@veprbl
Copy link
Member Author

veprbl commented Mar 17, 2020

Thank you for this.

You're welcome.

How much effort/computation the update takes?

Comparing to a usual package update, there is an extra effort, mostly routine.

@veprbl veprbl restored the pr/texlive_2019_final branch December 1, 2020 16:47
@veprbl veprbl deleted the pr/texlive_2019_final branch December 1, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple requested changes

@dtzWill dtzWill Awaiting requested review from dtzWill

@matthuszagh matthuszagh Awaiting requested review from matthuszagh

Assignees
No one assigned
Labels
6.topic: TeX Issues regarding texlive and TeX in general 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

texlive: grffile package is very outdated
3 participants
@veprbl @Anton-Latukha @bhipple