Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qxw: init at 20190909 #82175

Merged
merged 2 commits into from Sep 29, 2020
Merged

qxw: init at 20190909 #82175

merged 2 commits into from Sep 29, 2020

Conversation

tckmn
Copy link
Member

@tckmn tckmn commented Mar 9, 2020

Motivation for this change

Adds a derivation for the qxw program.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

puzzlewolf
puzzlewolf suggested changes Mar 29, 2020
View reviewed changes
Copy link
Contributor

@puzzlewolf puzzlewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the binary starts fine.

Commit message should be qxw: init at 20190909, just like PR title :)

@tckmn
Copy link
Member Author

tckmn commented Mar 31, 2020

@puzzlewolf whoops, sorry -- fixed that!

puzzlewolf
puzzlewolf approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@puzzlewolf puzzlewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

puzzlewolf
puzzlewolf suggested changes Apr 11, 2020
View reviewed changes
Copy link
Contributor

@puzzlewolf puzzlewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nitpick :)

pkgs/applications/editors/qxw/default.nix Outdated Show resolved Hide resolved
@tckmn
Copy link
Member Author

tckmn commented Sep 18, 2020

@puzzlewolf slightly delayed lol but fixed that as well! (and updated version because there's been a new one in the meantime)

@ryantm
Copy link
Member

ryantm commented Sep 29, 2020

Result of nixpkgs-review pr 82175 1

1 package built:
- qxw

@ryantm ryantm merged commit 990af06 into NixOS:master Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puzzlewolf puzzlewolf puzzlewolf requested changes

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tckmn @ryantm @puzzlewolf