Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] go_1_13: 1.13.1 -> 1.13.7, go_1_12: 1.12.9 -> 1.12.16 (backport) #79513

Merged
merged 11 commits into from Feb 9, 2020
Merged

[19.09] go_1_13: 1.13.1 -> 1.13.7, go_1_12: 1.12.9 -> 1.12.16 (backport) #79513

merged 11 commits into from Feb 9, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Feb 8, 2020 •
edited

Motivation for this change

Backport latest patch versions for go in 19.09 branch as there are tons of CVE fixed in them. I'm not sure what should be the process, but, IMO it's quite important from security point of view.

@kalbasit probably, you can advise, thank you!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@Frostman
Copy link
Member Author

Frostman commented Feb 8, 2020

nixpkgs-review pr 79513 succeded with 666 packages built

@kalbasit
Copy link
Member

kalbasit commented Feb 8, 2020

Please cherry-pick all backported commits with -x.

See https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes

d-goldin and others added 11 commits February 8, 2020 11:42
@d-goldin @Frostman
go_1_12: 1.12.9 -> 1.12.10
60f61ee 
GO 1.12.10 has been released 5 days ago, so
bumping it in the hope that it also fixes some
flakey GC tests.

Also see NixOS#69359

(cherry picked from commit aa46781)
@r-ryantm @Frostman
go: 1.13.1 -> 1.13.3
ef02b4b 
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/go/versions

(cherry picked from commit c307ed8)
@r-ryantm @Frostman
go: 1.13.3 -> 1.13.4
35ff7a5 
(cherry picked from commit eb87a73)
@fmpwizard @Frostman
go: do not replace path to zoneinfo.zip
29cfe27 
Prepend the nix path to the zoneinfo.zip file and keep the original alternatives
to allow go programs built using nix to run on non nix servers.

see NixOS#54603

(cherry picked from commit 5a0be78)
@fmpwizard @Frostman
go: do not replace path to mime.types
71d15fa 
(cherry picked from commit 051bc35)
@r-ryantm @Frostman
go: 1.13.4 -> 1.13.5 (NixOS#75236)
a02d497 
(cherry picked from commit 85a369d)
@thefloweringash @Frostman
go_1_12, go_1_13: skip TestExtraFiles on 32-bit arm (NixOS#76944)
3ca1c93 
The test is known to be flaky in some environments, and I'm seeing it
consistently in an armv7l-linux vm.

(cherry picked from commit ffd68f2)
@zowoq @Frostman
go: 1.13.5 -> 1.13.6
3ab3ddc 
(cherry picked from commit 116b5c5)
@zowoq @Frostman
go_1_12: 1.12.10 -> 1.12.15
5496ad1 
(cherry picked from commit 3e30f56)
@Frostman
go_1_12: 1.12.15 -> 1.12.16
8a335c6 
(cherry picked from commit 60bb60b)
@Frostman
go_1_13: 1.13.6 -> 1.13.7
6a9e8e6 
(cherry picked from commit 1092ba6)
@Frostman
Copy link
Member Author

Frostman commented Feb 8, 2020

Executed nixpkgs-review pr 79513 one more time just in case - works fine. With that PR go compiler in 19.09 is in sync with current unstable.

@kalbasit
Copy link
Member

kalbasit commented Feb 9, 2020

@GrahamcOfBorg build pet jx kubectl prow

@kalbasit kalbasit merged commit 018a6fd into NixOS:release-19.09 Feb 9, 2020
@Frostman Frostman deleted the stable-go-bump branch February 9, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

@velovix velovix Awaiting requested review from velovix

@Mic92 Mic92 Awaiting requested review from Mic92

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
6.topic: golang 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Frostman @kalbasit @d-goldin @r-ryantm @fmpwizard @thefloweringash @zowoq