Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.asyncssh: fix build #79422

Merged
merged 1 commit into from Feb 7, 2020
Merged

python3Packages.asyncssh: fix build #79422

merged 1 commit into from Feb 7, 2020

Conversation

andrew-d
Copy link
Contributor

@andrew-d andrew-d commented Feb 7, 2020

Motivation for this change

The test changed from yield from to await, which broke our patch.
Fix our patch.

Closes #79380

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

r? @worldofpeace

@andrew-d
python3Packages.asyncssh: fix build
5a0f000 
The test changed from `yield from` to `await`, which broke our patch.
Fix our patch.

Closes NixOS#79380
@andrew-d
Copy link
Contributor Author

andrew-d commented Feb 7, 2020

@GrahamcOfBorg build python3Packages.asyncssh

@worldofpeace worldofpeace merged commit 23fa449 into NixOS:master Feb 7, 2020
@worldofpeace
Copy link
Contributor

Thank you for fixing this @andrew-d ✨

@andrew-d andrew-d deleted the andrew/asyncssh branch March 29, 2020 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python3.pkgs.asyncssh fails to build
3 participants
@andrew-d @worldofpeace @marsam