Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spirv-cross: init at 2020-01-16 #79454

Merged
merged 1 commit into from Apr 21, 2020
Merged

spirv-cross: init at 2020-01-16 #79454

merged 1 commit into from Apr 21, 2020

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented Feb 7, 2020 •
edited

Motivation for this change

Add a package for SPIRV-Cross, a disassembler for SPIR-V to glsl.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Flakebi Flakebi force-pushed the spirv-cross branch 2 times, most recently from 9962345 to 3aab603 Compare February 27, 2020 09:10
timokau
timokau requested changes Mar 31, 2020
View reviewed changes
pkgs/tools/graphics/spirv-cross/default.nix Outdated Show resolved Hide resolved
pkgs/tools/graphics/spirv-cross/default.nix Outdated Show resolved Hide resolved
pkgs/tools/graphics/spirv-cross/default.nix Outdated Show resolved Hide resolved
@Flakebi
Copy link
Member Author

Flakebi commented Apr 21, 2020

@timokau Thanks for your review, I updated the package. Can you please re-review this? :)

timokau
timokau approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed your changes. Looks good to me now, thank you!

@timokau timokau merged commit 379f759 into NixOS:master Apr 21, 2020
@Flakebi Flakebi deleted the spirv-cross branch April 22, 2020 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar left review comments

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Flakebi @timokau @doronbehar