Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make myself a maintainer #79455

Merged
merged 2 commits into from Feb 8, 2020
Merged

Make myself a maintainer #79455

merged 2 commits into from Feb 8, 2020

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Feb 7, 2020

Motivation for this change

#79085 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Atemu Atemu changed the title Maintainers atemu Make myself a maintainer Feb 7, 2020
@worldofpeace
Copy link
Contributor

nit 39519d2, can the message not be uppercase Maintainers but just lower case?

@Atemu
Copy link
Member Author

Atemu commented Feb 7, 2020

Sure, is that the general code style for commit messages in nixpkgs?

@worldofpeace
Copy link
Contributor

Sure, is that the general code style for commit messages in nixpkgs?

Usually it's an attribute path or a file path https://github.com/NixOS/nixpkgs/commits/master/maintainers.
In this case the directory is not uppercase, and the attribute in stdenv.lib is maintainers.

@FRidh
Copy link
Member

FRidh commented Feb 8, 2020

cc @waynr

@worldofpeace worldofpeace merged commit 26d618b into NixOS:master Feb 8, 2020
@Atemu Atemu deleted the maintainers-atemu branch July 30, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants