Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.perhaps: add link to upstream PR #79456

Merged
merged 1 commit into from Feb 7, 2020
Merged

haskellPackages.perhaps: add link to upstream PR #79456

merged 1 commit into from Feb 7, 2020

Conversation

Taneb
Copy link
Contributor

@Taneb Taneb commented Feb 7, 2020

Motivation for this change

In #79330 @peti requested I add a link to the upstream PR, sadly after that PR was merged. This adds that note.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peti peti closed this Feb 7, 2020
@peti peti reopened this Feb 7, 2020
@peti peti merged this pull request into NixOS:haskell-updates Feb 7, 2020
@ofborg ofborg bot removed the 6.topic: haskell label Feb 7, 2020
@cdepillabout
Copy link
Member

@Taneb Thanks a lot for this quick follow-up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Taneb @cdepillabout @peti