Example runs:

Telemetry enabled

Output edited to improve readability.

Note that they assign unique values to:

• requestId
• installationId
• sessionId

 ./result-with-telemetry/bin/sam init --debug
Telemetry endpoint configured to be https://aws-serverless-tools-telemetry.us-west-2.amazonaws.com/metrics
Which template source would you like to use?
	1 - AWS Quick Start Templates
	2 - Custom Template Location
Choice: ^C
Sending Telemetry: {'metrics': 
 [
     {'commandRun': 
      {'awsProfileProvided': False, 
       'debugFlagProvided': True, 
       'region': '',
       'commandName': 'sam init', 
       'duration': 6709, 
       'exitReason': 'Abort', 
       'exitCode': 255, 
       'requestId': '<REDACTED>',
       'installationId': '<REDACTED>',
       'sessionId': '<REDACTED>',
       'executionEnvironment': 'CLI', 
       'pyversion': '3.7.6',
       'samcliVersion': '0.40.0'}
     }
 ]
}
HTTPSConnectionPool(host='aws-serverless-tools-telemetry.us-west-2.amazonaws.com', port=443): Read timed out. (read timeout=0.1)
Aborted!

Telemetry disabled

 ./result-no-telemetry/bin/sam init --debug
Which template source would you like to use?
	1 - AWS Quick Start Templates
	2 - Custom Template Location
Choice: ^C
Aborted!

Also note that the installation ID and telemetry options are saved in a configuration file (although the env var takes precedence):

cat ~/.aws-sam/metadata.json

{
    "telemetryEnabled": true,
    "installationId": "<REDACTED>"
}

LGTM

This is awesome. Thanks for this PR!

Anything else you need from me to get this merged, please do let me know.

Thanks for the awesome work you are doing on NixOS!

Hey @stefano-m, sorry for the delay in getting back to you.

Personally, I am okay with disabling telemetry by default (and thanks for being privacy-conscious!). I gave this a bit more thought and felt that by generating a wrapper around sam, it actually removes user's ability to opt into using telemetry, if they need that for whatever reason.

Can we generate the wrapper conditionally, so user's can actually override the default and opt in?

@dhl I can see your point, although I fail to understand why someone wanted to use telemetry (aws-sam-cli even disable it in their tests).

Note that for example powershell disables telemetry in the wrapper

(Disclosure: I somewhat contributed to those setting with #74516)

If you still prefer to have the option to enable telemetry, I would propose instead that we generate the wrapper with telemetry disabled by default and add a conditional parameter to the derivation to explicitly enable telemetry.

Would you be OK with that?

Thanks

I have just re-read your comment and actually you say

Can we generate the wrapper conditionally, so user's can actually override the default and opt in?

🤦‍♂️ ...

So, yes... I will do that. 🙇‍♂️

@GrahamcOfBorg build aws-sam-cli