grpcurl: add darwin as a supported platform #79442
Closed
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grpcurl works on Linux, macOS, and Windows. This adds darwin to the list of supported platforms, so nixpkgs build it there as well.
knl
force-pushed
the
grpcurl-works-on-darwin-too
branch
from
b023b87 to
decc173
Compare
ofborg
bot
added
6.topic: darwin
zimbatm
reviewed
Feb 7, 2020
| @@ -22,6 +22,7 @@ buildGoPackage rec { | |||
| description = "Like cURL, but for gRPC: Command-line tool for interacting with gRPC servers"; | |||
| homepage = https://github.com/fullstorydev/grpcurl; | |||
| license = stdenv.lib.licenses.mit; | |||
| platforms = with stdenv.lib.platforms; linux ++ darwin; | |||
There was a problem hiding this comment.
buildGoPackage seems to set platforms = lib.platforms.all if no value is provided.
See:
https://github.com/zimbatm/nixpkgs/blob/686125dbf9e1b5e933d3e74a7843bd9b1939d272/pkgs/development/go-packages/generic/default.nix#L242
There was a problem hiding this comment.
nix-repl> grpcurl.meta.platforms
[ "aarch64-linux" "armv5tel-linux" "armv6l-linux" "armv7a-linux" "armv7l-linux" "mipsel-linux" "i686-linux" "x86_64-linux" "powerpc64le-linux" "riscv32-linux" "riscv64-linux" "x86_64-darwin" "i686-darwin" "aarch64-darwin" "armv7a-darwin" ]
There was a problem hiding this comment.
and here is the latest hydra build:
https://hydra.nixos.org/eval/1569176?filter=grpcurl&compare=1569128&full=
There was a problem hiding this comment.
I should have checked better. Thanks! Will close the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
grpcurl works on Linux, macOS, and Windows. This adds darwin to the list
of supported platforms, so nixpkgs build it there as well.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)