Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scribusUnstable: Fix build with Poppler 0.84 #79585

Merged
merged 1 commit into from Feb 9, 2020
Merged

scribusUnstable: Fix build with Poppler 0.84 #79585

merged 1 commit into from Feb 9, 2020

Conversation

Kiwi
Copy link
Member

@Kiwi Kiwi commented Feb 9, 2020 •
edited

see: #77186 (comment)

it seems poppler updates (almost?) always break scribusUnstable

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Kiwi Kiwi mentioned this pull request Feb 9, 2020
Merged
@ofborg ofborg bot requested a review from erictapen February 9, 2020 04:06
@Kiwi
scribusUnstable: Fix build with Poppler 0.84
bef2837 
see: NixOS#77186 (comment)

it seems poppler updates (almost?) always break scribusUnstable

additionally:
formatted with nixpkgs-fmt;
added kiwi to maintainers - the more eyes the better;
add additional licenses that are listed on scribus COPYING;
@Kiwi Kiwi force-pushed the scribusUnstable-poppler-0.84 branch from f5e1012 to bef2837 Compare February 9, 2020 05:23
@worldofpeace worldofpeace merged commit 89e9f68 into NixOS:master Feb 9, 2020
@worldofpeace
Copy link
Contributor

@nh2 scribusUnstable is actually an unstable release made by scribus.

@erictapen
Copy link
Member

@Kiwi thanks!

@Kiwi Kiwi deleted the scribusUnstable-poppler-0.84 branch February 11, 2020 14:42
@veprbl veprbl mentioned this pull request Mar 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 nh2 left review comments

@erictapen erictapen Awaiting requested review from erictapen

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Kiwi @worldofpeace @erictapen @nh2