Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform-provider-keycloak: init at 1.20.0 #79418

Merged
merged 1 commit into from
Aug 8, 2020
Merged

terraform-provider-keycloak: init at 1.20.0 #79418

merged 1 commit into from
Aug 8, 2020
+29 −1

Conversation

eonpatapon
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package labels Feb 7, 2020
@ofborg ofborg bot requested review from ehmry and kalbasit February 7, 2020 06:46
@eonpatapon
Copy link
Contributor Author

terraform-provider-atlas repo seems to have disappear.

tested the build of all providers (eg nix-build -A terraform-providers)

@flokli
Copy link
Contributor

flokli commented Jul 9, 2020

This needs a rebase, as a lot in data.nix has changed in the meantime.

Did you check if just adding it to slugs in update-all, and treating it like most other providers works?

@eonpatapon eonpatapon force-pushed the terraform-providers branch from 2c97f87 to 5debd8c Compare August 8, 2020 14:52
@eonpatapon eonpatapon changed the title terraform-provider-keycloak: init at 1.15.0 terraform-provider-keycloak: init at 1.20.0 Aug 8, 2020
@eonpatapon
Copy link
Contributor Author

@flokli rebased and used the latest version

It can't be added to data.nix as the repo doesn't contain it's dependencies like the others. Also it's using go modules.

@flokli
Copy link
Contributor

flokli commented Aug 8, 2020 

4 packages built:
terraform-full terraform-providers.keycloak terraform_0_11-full terragrunt

@flokli flokli merged commit 3cece2b into NixOS:master Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry

@kalbasit kalbasit

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eonpatapon @flokli