Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broot: 0.12.2 -> 0.13.0 #79565

Merged
merged 1 commit into from Feb 9, 2020
Merged

broot: 0.12.2 -> 0.13.0 #79565

merged 1 commit into from Feb 9, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Feb 8, 2020

Motivation for this change

Changelog: https://github.com/Canop/broot/releases/tag/v0.13.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
Copy link
Contributor

bhipple commented Feb 8, 2020 •
edited

There's already a 0.13.1 with bugfixes: https://github.com/Canop/broot/releases. This thing seems to get a release every couple days.

I happen to have a change targeting the staging branch that's changing the cargoSha256 for the newer fetchcargo behavior: #78501

This is going to cause some merge conflicts, since this package is one of the 8 packages that does use the newer fetchcargo implementation. If this gets merged to master before staging hits I'll do the work to rebase and fix merge conflicts again.

CC @zimbatm

@ofborg ofborg bot requested a review from magnetophon February 8, 2020 21:33
@zimbatm
Copy link
Member

zimbatm commented Feb 9, 2020

Sounds good

@zimbatm zimbatm merged commit bc23368 into NixOS:master Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magnetophon magnetophon Awaiting requested review from magnetophon

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @bhipple @zimbatm