Fix #7885: [Fluidsynth] Use recommended method of setting sample rate #7983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsmh
changed the title
|
There's some tiny risk of popping if the mutex happens to be locked exactly when the render routine is called. The only potentially common situation would be if the user is adjusting volume, or playback state is being queried, so the risk should be quite small. Probably fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large changeset for a small change.
As the only way to get the sample rate for the synth is to install the music render routine, it has to be installed before the synth is ready for use. This means the render routine could risk being called while the synth is not fully set up.
For this reason, set up full mutex protection of the synth objects.