Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grocy: init at 2.6.0 #79485

Merged
merged 2 commits into from Feb 9, 2020
Merged

grocy: init at 2.6.0 #79485

merged 2 commits into from Feb 9, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Feb 7, 2020

Motivation for this change

grocy is a web-based household/inventory management solution for your home.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 requested review from elseym and globin February 7, 2020 23:46
@Ma27 Ma27 requested a review from fpletz February 8, 2020 00:06
@Ma27 @elseym
nixos/grocy: init module
13f7b75 
Co-authored-by: elseym <elseym@me.com>
@Ma27 Ma27 marked this pull request as ready for review February 9, 2020 20:58
@Ma27 Ma27 requested a review from infinisil as a code owner February 9, 2020 20:58
@Ma27 Ma27 merged commit c2f2366 into NixOS:master Feb 9, 2020
@Ma27 Ma27 deleted the grocy branch February 9, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elseym elseym elseym approved these changes

@globin globin Awaiting requested review from globin

@fpletz fpletz Awaiting requested review from fpletz

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ma27 @elseym