Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix immediate editing of reference constraints #546

Merged

Conversation

vespakoen
Copy link
Contributor

As promised, the fix for immediately editing reference dimensions.

The issue was that the editor was opened before redundant constraint check was done.

@whitequark
Copy link
Contributor

@ppd1990 Looks like Snap builds break Travis on every PR, could you please fix that?

@whitequark whitequark merged commit 3ed1719 into solvespace:master Feb 5, 2020
@whitequark
Copy link
Contributor

@vespakoen Thanks!

@ppd
Copy link
Member

ppd commented Feb 5, 2020

@whitequark I've been quite busy in the last weeks, so my apologies for the delay. I'll get right on proposing a fix.

@ppd
Copy link
Member

ppd commented Feb 7, 2020

@whitequark See #547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants