-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
ifconfig-parser and jc: init #79452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ifconfig-parser and jc: init #79452
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit history should be:
pythonPackages.ifconfig-parser: init at 0.0.5
pythonPackages.jc: init at 1.7.2
getting the changes to python-modules is a little more difficult, but you can use |
Thanks! I usually like to keep the history transparent but this is definitely cleaner.
A rebase with rewords and fixups is easier IMO and avoids the second issue |
a774ec6
to
fb9a51b
Compare
please fix conflicts |
Thanks a bunch for your feedback @jonringer! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
jc shows usage
[8 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/79452
5 package built:
jc python27Packages.ifconfig-parser python37Packages.ifconfig-parser python38Packages.ifconfig-parser python38Packages.jc
@GrahamcOfBorg eval |
Updated to 1.7.5. Btw, what's the status on this? I'm not too familiar with the process of adding a package yet. |
@GrahamcOfBorg build jc python27Packages.ifconfig-parser python37Packages.ifconfig-parser python38Packages.ifconfig-parser python38Packages.jc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[8 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/79452
5 package built:
jc python27Packages.ifconfig-parser python37Packages.ifconfig-parser python38Packages.ifconfig-parser python38Packages.jc
the status was: I forgot to follow up after doing ofborg |
Motivation for this change
https://www.reddit.com/r/linux/comments/ezvj04/jc_jsonify_the_output_of_dozens_of_common/
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)