Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gateware.analyzer: FIFO tests are broken #182

Open
emilazy opened this issue Feb 8, 2020 · 1 comment
Open

gateware.analyzer: FIFO tests are broken #182

emilazy opened this issue Feb 8, 2020 · 1 comment
Labels
software Component: software

Comments

@emilazy
Copy link
Contributor

emilazy commented Feb 8, 2020

gateware.analyzer:EventAnalyzerTestCase.test_delay_{{2,3}_septet,max,overflow{,_p1}} currently fail (potentially nondeterministically?). They should probably not fail. I'm creating this issue so I can disable them for now.
emilazy added a commit to emilazy/glasgow that referenced this issue Feb 8, 2020
@emilazy
gateware.analyzer: disable broken FIFO tests.
77d0b3b 
See issue GlasgowEmbedded#182.
@whitequark whitequark added the software Component: software label Feb 8, 2020
@emilazy emilazy mentioned this issue Feb 8, 2020
Merged
emilazy added a commit to emilazy/glasgow that referenced this issue Feb 8, 2020
@emilazy
gateware.analyzer: disable broken FIFO tests.
a905779 
See issue GlasgowEmbedded#182.
emilazy added a commit to emilazy/glasgow that referenced this issue Feb 8, 2020
@emilazy
gateware.analyzer: disable broken FIFO tests.
df1ed93 
See issue GlasgowEmbedded#182.
emilazy added a commit to emilazy/glasgow that referenced this issue Feb 8, 2020
@emilazy
gateware.analyzer: disable broken FIFO tests.
2525912 
See issue GlasgowEmbedded#182.
@emilazy
Copy link
Contributor Author

emilazy commented Feb 8, 2020

test_delay_4_septet too, so it seems there is indeed some nondeterminism at play here. :(

whitequark pushed a commit that referenced this issue Feb 8, 2020
@emilazy @whitequark
gateware.analyzer: disable broken FIFO tests.
2a8bfc9 
See issue #182.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
software Component: software
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whitequark @emilazy