Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unixODBCDrivers.msodbcsql17: 17.4.1.1 -> 17.5.1.1 #79482

Merged
merged 1 commit into from
Feb 9, 2020
Merged

unixODBCDrivers.msodbcsql17: 17.4.1.1 -> 17.5.1.1 #79482

merged 1 commit into from
Feb 9, 2020
+2 −2

Conversation

spencerjanssen
Copy link
Contributor

Motivation for this change

Updating to latest version. Confirmed the driver can connect to and query SQL Server.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 7, 2020
aanderse
aanderse approved these changes Feb 9, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spencerjanssen feel free to ping me any time for a merge on this package. Thanks for updating! 🎉

PS. at some point we should try and upgrade to the Debian 10 variant again... no rush on that, though.

@aanderse aanderse merged commit a7a3135 into NixOS:master Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spencerjanssen @aanderse