Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goldendict: enable on darwin #79550

Merged
merged 1 commit into from Feb 15, 2020
Merged

goldendict: enable on darwin #79550

merged 1 commit into from Feb 15, 2020

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Feb 8, 2020

Motivation for this change
  • ❗ Enable on Darwin
  • Update 2019-08-01 -> 2020-01-09 (diff)
  • Disable checking for new release
  • Added options: withCC, withEpwing, withExtraTiff, withFFmpeg, withMultimedia, withZim
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Feb 8, 2020
@vcunat
Copy link
Member

vcunat commented Feb 8, 2020

@GrahamcOfBorg build goldendict

@gebner gebner merged commit 6d12da3 into NixOS:master Feb 15, 2020
@sikmir sikmir deleted the goldendict branch February 16, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants