Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qttools: Add qtdeclarative to buildInputs #79558

Merged
merged 1 commit into from Feb 11, 2020
Merged

qttools: Add qtdeclarative to buildInputs #79558

merged 1 commit into from Feb 11, 2020

Conversation

Thra11
Copy link
Member

@Thra11 Thra11 commented Feb 8, 2020

qtdeclarative is an optional dependency for some parts of qttools:
without it, the lupdate binary is not able to process qml files for
translatable strings.

Motivation for this change

I tried to run lupdate on some qml files and it did nothing and output the following warning:

warning: Some files have been ignored due to missing qml/javascript support
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Thra11 Thra11 requested a review from ttuegel as a code owner February 8, 2020 19:40
@Thra11
Copy link
Member Author

Thra11 commented Feb 8, 2020

Ouch! That's a lot of rebuilds. To be expected though. Might be worth checking whether there are any other missing dependencies so we can sneak them all in in one go.

@veprbl
Copy link
Member

veprbl commented Feb 9, 2020

Ouch! That's a lot of rebuilds.

Eight hundred for x86_64-linux. I would consider targeting this to the staging branch instead of master.

@Thra11 @ttuegel
qttools: Add qtdeclarative to buildInputs
704b49d 
qtdeclarative is an optional dependency for some parts of qttools:
without it, the lupdate binary is not able to process qml files for
translatable strings.
@FRidh
Copy link
Member

FRidh commented Feb 11, 2020

Please target staging branch.

@FRidh FRidh added this to Needs review in Staging Feb 11, 2020
@ttuegel ttuegel changed the base branch from master to staging February 11, 2020 10:52
ttuegel
ttuegel approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I tested on staging myself.

Staging automation moved this from Needs review to Ready Feb 11, 2020
@ttuegel ttuegel merged commit f9ddb17 into NixOS:staging Feb 11, 2020
Staging automation moved this from Ready to Done Feb 11, 2020
@Thra11 Thra11 deleted the add-qtdeclarative-qttools branch February 11, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
6.topic: qt/kde 8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Thra11 @veprbl @FRidh @ttuegel