Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stylish haskell by using HsYAML 0.2.1.0 #79528

Merged
merged 2 commits into from Feb 8, 2020
Merged

Fix stylish haskell by using HsYAML 0.2.1.0 #79528

merged 2 commits into from Feb 8, 2020

Conversation

clkamp
Copy link
Contributor

@clkamp clkamp commented Feb 8, 2020

Fixes #79130

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout cdepillabout merged commit 89ae888 into NixOS:haskell-updates Feb 8, 2020
@cdepillabout
Copy link
Member

Looks good, thanks for fixing this up!

@clkamp clkamp deleted the fix-stylish-haskell branch February 8, 2020 19:26
@rpearce rpearce mentioned this pull request Feb 11, 2020
Closed
@rpearce
Copy link
Contributor

rpearce commented Feb 11, 2020

Thank you for this

@turboMaCk
Copy link
Member

Oh great that this is fixed and merged, thanks!

@rpearce
Copy link
Contributor

rpearce commented Feb 21, 2020

Looks like this was merged 13 days ago...is it out in the world yet? I'm not picking it up in the unstable channel, but I'm also not the most experienced nixer

@turboMaCk
Copy link
Member

I've added it to my custom overlay https://github.com/turboMaCk/Dotfiles/blob/master/nixos/overlays/haskell.nix

@rpearce
Copy link
Contributor

rpearce commented Feb 21, 2020

Gotcha! I did the same late last night, and it's all 👍. Thank you

https://github.com/rpearce/.config/blob/a2bb839dea4ad7d49d8e1d5091ffe996e677178e/nix/nixpkgs/config.nix#L12-L21

benkolera added a commit to benkolera/nix that referenced this pull request Feb 25, 2020
@benkolera
fix: okay, try this stylish-haskell fix
71f6479 
See: NixOS/nixpkgs#79528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@clkamp @cdepillabout @rpearce @turboMaCk