Skip to content

nixos/pulseaudio: Enable udev rules #79481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2020
Merged

nixos/pulseaudio: Enable udev rules #79481

merged 1 commit into from
Feb 8, 2020
+3 −0

Conversation

spencerjanssen
Copy link
Contributor

Motivation for this change

PulseAudio comes with udev rules that set proper profiles and work around various device quirks. For example, my USB headset was incorrectly detected as mono without these rules.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 7, 2020
@worldofpeace worldofpeace merged commit 313f44c into NixOS:master Feb 8, 2020
@worldofpeace
Copy link
Contributor

Thank you @spencerjanssen 👍

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 8, 2020
@worldofpeace @dtzWill
Merge pull request NixOS#79481 from spencerjanssen/pulseaudio-udev-rules

Verified

This commit was signed with the committer’s verified signature. The key has expired.
dtzWill Will Dietz
GPG key ID: EBB0EA4124809D02
Expired
Verified
Learn about vigilant mode
aee1ee5 
nixos/pulseaudio: Enable udev rules

(cherry picked from commit 313f44c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spencerjanssen @worldofpeace