Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] youtube-dl: 2019.11.05 -> 2020.01.24 #78605

Merged
merged 1 commit into from Jan 27, 2020
Merged

[19.09] youtube-dl: 2019.11.05 -> 2020.01.24 #78605

merged 1 commit into from Jan 27, 2020

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Jan 27, 2020

Motivation for this change

Backport of #78433, unbreaking youtube-dl not working at all on YouTube.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@arcnmx @nh2
youtube-dl: 2019.11.05 -> 2020.01.24
b53ed87 
Fixes downloading from YouTube, see NixOS#78433.

(cherry picked from commit e0e2fd8)
@nh2 nh2 self-assigned this Jan 27, 2020
@nh2 nh2 mentioned this pull request Jan 27, 2020
Merged
10 tasks
@nh2
Copy link
Contributor Author

nh2 commented Jan 27, 2020

@GrahamcOfBorg build

@nh2
Copy link
Contributor Author

nh2 commented Jan 27, 2020

nix-review is happy with it:

23 package were built:
bomi celluloid curseradio deepin.dde-file-manager deepin.deepin-movie-reborn kodi-cli lollypop minitube mopidy-youtube mpc-qt mpv mpv-with-scripts persepolis plex-media-player python27Packages.pafy python27Packages.youtube-dl python27Packages.youtube-dl-light python37Packages.mps-youtube python37Packages.mpv python37Packages.pafy youtube-dl youtube-dl-light ytcc

@nh2 nh2 merged commit 845b911 into NixOS:release-19.09 Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fuuzetsu Fuuzetsu Awaiting requested review from Fuuzetsu

@bluescreen303 bluescreen303 Awaiting requested review from bluescreen303

@fpletz fpletz Awaiting requested review from fpletz

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@Phreedom Phreedom Awaiting requested review from Phreedom

Assignees

@nh2 nh2

Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nh2 @arcnmx