Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09] chromium: 79.0.3945.88 -> 79.0.3945.130 (backport) #78603

Merged
merged 3 commits into from Jan 31, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Jan 27, 2020

Motivation for this change

We can either skip #78022 and focus on this PR or merge the older PR for 79.0.3945.117 first.

This is a backport of #78584 and also cherry-picks a fix for the AArch64 build (which is currently failing on 19.09: https://hydra.nixos.org/build/110325603).

platform attribute status tester
x86_64 chromium ✔️ @primeos
x86_64 nixosTests.chromium - @primeos
x86_64 google-chrome ✔️ @primeos
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The skia patch no longer applies, and is no longer necessary.

The current version of chromium doesn't build with gcc. This has been
fixed upstream[1] and could be backported, but switching aarch64 to
clang/llvm and making the build the same on all platforms is simpler.

[1] https://chromium.googlesource.com/chromium/src/+/9662ec844017690d5fd56bf0f05ef6a540dd29c1

(cherry picked from commit 6ec5e74)
@primeos
Copy link
Member Author

primeos commented Jan 31, 2020

Finally got around to test this on 19.09. I didn't notice anything strange, should be fine :)

@primeos primeos merged commit 48e29aa into NixOS:release-19.09 Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants