Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arrow-cpp: fix for darwin #78614

Merged
merged 1 commit into from Jan 28, 2020
Merged

arrow-cpp: fix for darwin #78614

merged 1 commit into from Jan 28, 2020

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Jan 27, 2020

Using pkgsStatic.gtest fails to link, so we just use the default.
This makes gtest part of the closure, which thereby grows from 216.2M to 216.4M.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @matthewbauer @veprbl

@tobim
arrow-cpp: fix for darwin
da0334c 
Using pkgsStatic.gtest fails to link, so we just use the default.
@veprbl
Copy link
Member

veprbl commented Jan 27, 2020

I think, we needed static libraries in the previous versions of arrow, but, I guess, not anymore.

@GrahamcOfBorg build arrow-cpp

veprbl
veprbl approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes nix-review on NixOS x86_64-linux:

4 package failed to build:
python37Packages.google_cloud_bigquery python37Packages.ibis-framework python38Packages.google_cloud_bigquery python38Packages.ibis-framework

15 package built:
arrow-cpp python27Packages.awkward python27Packages.pyarrow python27Packages.snowflake-connector-python python27Packages.snowflake-sqlalchemy python27Packages.uproot python27Packages.uproot-methods python37Packages.awkward python37Packages.pyarrow python37Packages.uproot python37Packages.uproot-methods python38Packages.awkward python38Packages.pyarrow python38Packages.uproot python38Packages.uproot-methods

@veprbl veprbl merged commit 8c651aa into NixOS:master Jan 28, 2020
@tobim tobim deleted the darwin/fix-arrow-cpp branch January 28, 2020 22:38
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@tobim @anna328p
arrow-cpp: fix for darwin (NixOS#78614)
6146775 
Using pkgsStatic.gtest fails to link, so we just use the default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tobim @veprbl