Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

faust: 2.5.23 -> 2.20.2 #78613

Merged
merged 1 commit into from Feb 10, 2020
Merged

faust: 2.5.23 -> 2.20.2 #78613

merged 1 commit into from Feb 10, 2020

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Jan 27, 2020 •
edited

Motivation for this change

Some faust scripts only work in nix-shell, see #78610.
In the current faust, one script is broken altogether, this PR fixes that.
Some scripts still don't work in normal shell though...

I'm using llvm_9 cause the default, llvm_7, didn't work.
All the others work, so I figured I'd use the newest.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh FRidh merged commit bd90b5a into NixOS:master Feb 10, 2020
@magnetophon magnetophon mentioned this pull request Feb 28, 2020
Closed
10 tasks
@magnetophon magnetophon mentioned this pull request Mar 15, 2020
Merged
10 tasks
Artturin
Artturin reviewed Jul 4, 2022
View reviewed changes
pkgs/applications/audio/faust/faust2.nix
substituteInPlace compiler/Makefile.unix \
--replace "5.0.0 5.0.1" "5.0.0 5.0.1 5.0.2"
cmakeFlags = ''
-C ../backends/all.cmake -C ../targets/all.cmake ..
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

were the trailing .. added on purpose?

#180067

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested without them, and all seems fine, so I guess they weren't on purpose.

@Artturin Artturin mentioned this pull request Jul 5, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Artturin Artturin Artturin left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@magnetophon @Artturin @FRidh